Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump yaru and flutter versions #1465

Merged
merged 5 commits into from
Oct 23, 2023
Merged

feat: bump yaru and flutter versions #1465

merged 5 commits into from
Oct 23, 2023

Conversation

d-loose
Copy link
Member

@d-loose d-loose commented Oct 19, 2023

@d-loose d-loose requested a review from tim-hm October 19, 2023 15:25
@Feichtmeier
Copy link
Member

Note: if you want the gtk4 paned look, you just need to make the title bars transparent and set the border to borderside.none

tim-hm
tim-hm reviewed Oct 23, 2023
View reviewed changes
pubspec.yaml Outdated
sdk: '>=3.0.6 <3.0.7'
flutter: '>=3.10.6 <3.10.7'
sdk: '>=3.1.0 <4.0.0'
flutter: '>=3.13.0'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as in firmware-updater about fixing to a specific version rather than a range

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it to 3.13.7 here as well

tim-hm
tim-hm approved these changes Oct 23, 2023
View reviewed changes
Copy link

@tim-hm tim-hm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment ref versions but otherwise lgtm

@tim-hm
Copy link

tim-hm commented Oct 23, 2023

Note: if you want the gtk4 paned look, you just need to make the title bars transparent and set the border to borderside.none

We are planning on updating the visuals ... just not queit yet as we have a lot of plubing to address first.

@Feichtmeier
Copy link
Member

.

Sure, just wanted to give a heads up that some things are auto changing with the new version, for example the sidebar has darker/lighter color now in light/dark themes (noted and acked by elio, too)
Other changes are opt-in if wanted

@d-loose d-loose force-pushed the bump-versions branch 2 times, most recently from ca40942 to f1634a9 Compare October 23, 2023 10:24
@d-loose d-loose merged commit 1e005ae into ubuntu:main Oct 23, 2023
8 checks passed
@d-loose d-loose deleted the bump-versions branch October 23, 2023 12:21
ashuntu pushed a commit to ashuntu/app-center that referenced this pull request Feb 28, 2024
@d-loose
feat: bump yaru and flutter versions (ubuntu#1465)
c977beb 
* chore: bump flutter and yaru versions

* feat(ci): use asdf to manage flutter version

* docs: update flutter installation instructions

* chore(snap): bump flutter version

* feat: fix flutter version in pubspec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-hm tim-hm tim-hm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d-loose @Feichtmeier @tim-hm